Open
Conversation
Author
|
Missed the other PR since my last journey. Will merge the changes on the trip home. |
nschum
force-pushed
the
error-handling
branch
from
47392e8 to
dd87db9
Compare
Unlike the ICE portal, the SNCF portal just times out outside the TGV. That means no error handlers were called until 1 minute has passed.
nschum
force-pushed
the
error-handling
branch
from
dd87db9 to
b759dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had the pleasure of traveling with a misbehaving ICE portal, giving me the opportunity the check and improve the error handling. 😉
Also deduplicated code to reduce the risk of future missing handlers.